Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): pin httpbis-digest-headers version #277

Merged
merged 2 commits into from
Sep 7, 2023
Merged

chore(deps): pin httpbis-digest-headers version #277

merged 2 commits into from
Sep 7, 2023

Conversation

raducristianpopa
Copy link
Member

Changes proposed in this pull request

Specify the version of httpbis-digest-headers in order to fetch it from the NPM registry instead of GitHub.

Context

@changeset-bot
Copy link

changeset-bot bot commented Sep 6, 2023

🦋 Changeset detected

Latest commit: 3264eeb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@interledger/http-signature-utils Patch
@interledger/open-payments Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@raducristianpopa
Copy link
Member Author

raducristianpopa commented Sep 6, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 3264eeb

The changes in this PR will be included in the next version bump.
This PR includes changesets to release 2 packages
Name Type
@interledger/http-signature-utils Patch
@interledger/open-payments Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Why does it include @interledger/open-payments as well, when only http-signature-utils is mentioned in the changeset file? 🤔

Edit: Is this the reason?

open-payments/.changeset/config.json

Line 9 in 1379177

"updateInternalDependencies": "patch",

@sabineschaller
Copy link
Member

Why does it include @interledger/open-payments as well, when only http-signature-utils is mentioned in the changeset file? 🤔

Edit: Is this the reason?

open-payments/.changeset/config.json

Line 9 in 1379177

"updateInternalDependencies": "patch",

I think that's it. @mkurapov please confirm.

@mkurapov
Copy link
Contributor

mkurapov commented Sep 6, 2023 •
edited
Loading

Yep, because open-payments has http-signature-utils as a dependency

@raducristianpopa raducristianpopa merged commit 805d6dd into main Sep 7, 2023
@raducristianpopa raducristianpopa deleted the rp--update-dependency branch September 7, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabineschaller sabineschaller sabineschaller approved these changes

@mkurapov mkurapov Awaiting requested review from mkurapov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raducristianpopa @sabineschaller @mkurapov